Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to indicate that healthcheck is performed for skaffold apply #6741

Closed
dorbin opened this issue Oct 18, 2021 · 1 comment · Fixed by #6779
Closed

Update docs to indicate that healthcheck is performed for skaffold apply #6741

dorbin opened this issue Oct 18, 2021 · 1 comment · Fixed by #6779
Labels

Comments

@dorbin
Copy link
Contributor

dorbin commented Oct 18, 2021

Expected behavior

Documentation should indicate that healthcheck is performed for skaffold apply.

Actual behavior

Doc references healthcheck as if only included in processing of skaffold deploy.

Information

  • Skaffold version:
  • Operating system:
  • Installed via:
  • Contents of skaffold.yaml:
<paste your skaffold.yaml here>

Steps to reproduce the behavior

  1. a clonable repository with the sample skaffold project
  2. skaffold <command>
  3. ...
@aaron-prindle aaron-prindle added kind/todo implementation task/epic for the skaffold team area/docs priority/p2 May take a couple of releases kind/documentation and removed kind/todo implementation task/epic for the skaffold team labels Oct 18, 2021
@nkubala
Copy link
Contributor

nkubala commented Oct 29, 2021

thanks for pointing this out @dorbin, our documentation is in constant need of love 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants