Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious warning when using only remote manifests #5818

Closed
ekuefler opened this issue May 11, 2021 · 1 comment · Fixed by #5861
Closed

Spurious warning when using only remote manifests #5818

ekuefler opened this issue May 11, 2021 · 1 comment · Fixed by #5861
Labels
area/logging help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/bug Something isn't working planning/Q2-21 priority/p2 May take a couple of releases
Milestone

Comments

@ekuefler
Copy link

Expected behavior

I should be able to define a kubectl deploy using only remoteManifests without any issues.

Actual behavior

If I only define remoteManifests, I get a warning like this when running skaffold run:

Starting deploy...
WARN[0001] k8s/*.yaml did not match any file            
 - deployment.apps/manager configured
Waiting for deployments to stabilize...
Deployments stabilized in 13.710431ms

Information

  • Skaffold version: v1.23.0
  • Operating system: Linux
  • Installed via: skaffold.dev
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2beta15
kind: Config
metadata:
  name: environments
build:
  ...
deploy:
  kubectl:
    remoteManifests:
    - environments-system:deployment/manager

Notes

I get the same warning if I explicitly set manifests to an empty array. I think there just needs to be a check against remoteManifests here:

if c.Deploy.KubectlDeploy != nil && len(c.Deploy.KubectlDeploy.Manifests) == 0 {
.

@tejal29 tejal29 added kind/bug Something isn't working area/logging priority/p2 May take a couple of releases help wanted We would love to have this done, but don't have the bandwidth, need help from contributors labels May 17, 2021
@tejal29
Copy link
Contributor

tejal29 commented May 17, 2021

Thanks @ekuefler. We will try to clean up this up in our next sustainability sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/bug Something isn't working planning/Q2-21 priority/p2 May take a couple of releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants