Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire intents at end of dev loop #5621

Closed
briandealwis opened this issue Apr 1, 2021 · 1 comment
Closed

Expire intents at end of dev loop #5621

briandealwis opened this issue Apr 1, 2021 · 1 comment
Assignees
Milestone

Comments

@briandealwis
Copy link
Member

We currently queue up intents the control API if they can't be applied at the moment. We should expire intents when they cannot be applied.

From #5553 (comment):

I think @nkubala intended to have them queue up (like a single deploy request followed some time later by a single build request would run build and deploy both once)

this is what i intended at the time, but now i'm not so sure it's what we want. it might be a more predictable UX to just reject the intents sent by a user if skaffold isn't ready to take the corresponding action yet (e.g. receives build intent from user, but r.changeSet.needsRebuild == false

Maybe a better flow would be if buildIntent == true but r.changeSet.needsRebuild == false we expire it immediately and show output Checking build status: already up-to-date and similarly for sync and deploy.

if we decide to keep the current behavior, this is definitely something we should do. whatever route we take let's try and eliminate confusion.

@nkubala nkubala self-assigned this Apr 1, 2021
@nkubala nkubala added this to the v1.22.0 milestone Apr 1, 2021
@nkubala
Copy link
Contributor

nkubala commented Apr 8, 2021

fixed by #5636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants