Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templated fields, use generated tag for helm appVersion #5113

Closed
msonnleitner opened this issue Dec 5, 2020 · 4 comments
Closed

Templated fields, use generated tag for helm appVersion #5113

msonnleitner opened this issue Dec 5, 2020 · 4 comments
Labels
area/tag kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@msonnleitner
Copy link

Expected behavior

Support for using the generated tag to use in deployment, e.g. using that in the appVersionfield of the helm deployment

Actual behavior

Currently, the tag cannot (afaik) be used in that context.

Information

  • Skaffold version: v1.17.0
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2beta8
kind: Config
metadata:
  name: some-service
build:
  artifacts:
    - image: eu.gcr.io/tools-org/some-service
deploy:
  helm:
    releases:
      - name: some-service
        chartPath: helm/some-service
        artifactOverrides:
          image: eu.gcr.io/tools-org/some-service
        packaged:
          appVersion: {{.GENERATED_TAG}}
@tejal29 tejal29 added area/tag deploy/helm3 kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Dec 8, 2020
@nkubala
Copy link
Contributor

nkubala commented Dec 14, 2020

@msonnleitner the tag skaffold generates is actually available using {{.IMAGE_TAG}}. this was added in #4278 and shipped with v1.11.0.

@nkubala nkubala closed this as completed Dec 14, 2020
@msonnleitner
Copy link
Author

That variable exists, however I could not get it to work in appVersion.

So basically it seems that

  • appVersion takes ENV variables like FOO
  • appVersion does not take IMAGE_TAG
  • IMAGE_TAG works in setValueTemplates

@malins
Copy link

malins commented Feb 9, 2021

Hello @msonnleitner,

have you been able to solve this? I'm also trying to get the built tag into my helm chart as appVersion, but I'm failing.

Thank you,
Manuel

@msonnleitner
Copy link
Author

Hi @malins
I haven't been able to solve that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tag kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

4 participants