Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an installer for windows to replace the use of chocolatey #5089

Open
IsaacPD opened this issue Dec 1, 2020 · 3 comments
Open

Create an installer for windows to replace the use of chocolatey #5089

IsaacPD opened this issue Dec 1, 2020 · 3 comments
Labels
meta/release priority/p2 May take a couple of releases

Comments

@IsaacPD
Copy link
Contributor

IsaacPD commented Dec 1, 2020

At the moment skaffold is not able to properly clean up because of the behaviour of chocolatey as tracked in #4815. This behavior is important to skaffold and should not be compromised to use chocolatey. In order to replace the functionality chocolatey provides, a windows installer should be provided that accomplishes what chocolatey provides, namely installing to PATH and updating.

@gsquared94 gsquared94 added kind/feature-request priority/p2 May take a couple of releases triage/discuss Items for discussion meta/release and removed kind/feature-request labels Dec 1, 2020
@gsquared94
Copy link
Contributor

Let's discuss in triage

@nkubala nkubala removed the triage/discuss Items for discussion label Dec 14, 2020
@IsaacPD
Copy link
Contributor Author

IsaacPD commented Dec 29, 2020

I have got some code that is able to create an installer using NSIS here https://github.com/IsaacPD/skaffold/tree/nsis-windows-installer

The installer can:

  • Install to a user specified directory
  • Add that directory to the user's PATH
  • Uninstall skaffold and remove that directory from their path

There is also support to install additional files as is common on windows installers if we are interested on that.

Preference has shifted to using NSIS instead of WIX because it can be built on platforms other than windows. Thanks to @briandealwis for bringing NSIS to my attention.

@briandealwis
Copy link
Member

It seems like we may be better off integrating with Windows Package Manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/release priority/p2 May take a couple of releases
Projects
None yet
Development

No branches or pull requests

4 participants