Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website says: "fl Search this site..." #4993

Closed
steren opened this issue Nov 3, 2020 · 8 comments
Closed

Website says: "fl Search this site..." #4993

steren opened this issue Nov 3, 2020 · 8 comments

Comments

@steren
Copy link

steren commented Nov 3, 2020

image

I guess "fl" is a typo?

@tejal29
Copy link
Contributor

tejal29 commented Nov 3, 2020

Thanks @steren definitely a typo

@tejal29
Copy link
Contributor

tejal29 commented Nov 3, 2020

Can you please mention which page you see this ?
i don't see it on skaffold.dev
image

@chanseokoh
Copy link
Member

chanseokoh commented Nov 3, 2020

image

Every page. It's from these  which is supposed to be a magnifying glass icon.

image

Note two instances of placeholder="&#xf002 Search this site…" below:

<input type="search" class="form-control td-search-input" placeholder="&#xf002 Search this site…" aria-label="Search this site…" autocomplete="off">
  </div>
  ...
  <div id="td-sidebar-menu" class="td-sidebar__inner">
  <form class="td-sidebar__search d-flex align-items-center">

  <input type="search" class="form-control td-search-input" placeholder="&#xf002 Search this site…" aria-label="Search this site…" autocomplete="off">

I think this is when using a wrong font. For example, removing the Awesome font from this example will render "fl" instead of the icon.

@IsaacPD
Copy link
Contributor

IsaacPD commented Nov 3, 2020

I believe you are correct, I had not even noticed that there was supposed to be a search icon there. Some browsers seem to render it differently as for me on mac on Chrome it only shows a blank space, on Safari the magnifying glass is there, and on Firefox it is rendered as "fl". I imagine you are using Firefox?

@chanseokoh
Copy link
Member

I an using Chrome on my corp laptop (Linux). Honestly I've seen this "fl" for maybe more than a year, but I was too lazy to report before @steren did.

@tejal29
Copy link
Contributor

tejal29 commented Nov 6, 2020

I an using Chrome on my corp laptop (Linux). Honestly I've seen this "fl" for maybe more than a year, but I was too lazy to report before @steren did.

:) no worries @chanseokoh. you forced me to log into corp laptop. But yes now i can see the "fi"

image

@IsaacPD
Copy link
Contributor

IsaacPD commented Nov 10, 2020

Oddly I noticed that the magnifying glass does initially appear for me on Chrome/Firefox on Mac for a split second before it goes back to an empty space/"fl". By continuously refreshing it was easier to notice it appearing and then disappearing.

@IsaacPD
Copy link
Contributor

IsaacPD commented Nov 10, 2020

I managed to make the magnifying glass appear within my browser by changing the font used for that element from "font awesome 5 free" to "FontAwesome"

<div class="skaffold-navbar navbar-nav d-none d-lg-block">{{ partial "search-input.html" . }}</div>

The search-input.html partial is part of docsy so it must be due to one of the style sheets I guess.

Also closing since this issue is a duplicate of #4903

Screen Shot 2020-11-10 at 6 31 19 PM

@IsaacPD IsaacPD closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants