Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using kustomize buildin in kubectl breaks compatibility with kustomize 3.X features #4232

Closed
mobuchowski opened this issue May 20, 2020 · 4 comments · Fixed by #4237
Closed

Using kustomize buildin in kubectl breaks compatibility with kustomize 3.X features #4232

mobuchowski opened this issue May 20, 2020 · 4 comments · Fixed by #4237
Labels
kind/bug Something isn't working priority/p1 High impact feature/bug.

Comments

@mobuchowski
Copy link

Expected behavior

Skaffold will continue working with kustomize 3.X features if I have kustomize binary in PATH.

Actual behavior

Skaffold forces using outdated kubectl version of kustomize

Information

  • Skaffold version: version 1.10
  • Operating system: OS X 10.15.4

This problem with buildin kustomize is relevant to me
kubernetes-sigs/kustomize#1373 (comment)
@mobuchowski mobuchowski changed the title Using kustomize buildin kubectl breaks compatibility with kustomize 3.X features Using kustomize buildin in kubectl breaks compatibility with kustomize 3.X features May 20, 2020
@niklasbuechner
Copy link

I have unfortunately the same problem. We have been using kustomize v3.5.4 which now fails. Is there a workaround available?

@mobuchowski
Copy link
Author

@niklasbuechner my workaround is to downgrade to 1.9.1.

@tstromberg
Copy link
Contributor

/cc @balopat

@tstromberg tstromberg added kind/bug Something isn't working priority/p1 High impact feature/bug. labels May 20, 2020
@nkubala
Copy link
Contributor

nkubala commented May 20, 2020

i broke this in #4183. i'm going to revert this change for now and do a hotfix release until we can figure out how to properly address this. sorry for the inconvenience 😞

@nkubala nkubala mentioned this issue May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working priority/p1 High impact feature/bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "use kubectl's built-in kustomize when possible" GoogleContainerTools/skaffold
4 participants
@tstromberg @nkubala @mobuchowski @niklasbuechner