Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold render --output takes GCS file path #3902

Closed
ChrisGe4 opened this issue Apr 1, 2020 · 2 comments
Closed

skaffold render --output takes GCS file path #3902

ChrisGe4 opened this issue Apr 1, 2020 · 2 comments
Labels
area/render good first issue Good for newcomers help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@ChrisGe4
Copy link
Contributor

ChrisGe4 commented Apr 1, 2020

I would like to make a proposal to add functionality to allow --output flag to take a GCS path for skaffold render

if the value I pass to --output starts with gs://, skaffold should treat it as a GCS path.

possible solution:

Call gsutil in https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/deploy/util.go#L86 if filepath starts with gs://
@tejal29 tejal29 added the priority/p3 agreed that this would be good to have, but no one is available at the moment. label Apr 6, 2020
@nkubala
Copy link
Contributor

nkubala commented Apr 7, 2020

hey @ChrisGe4, thanks for filing. functionally this would be equivalent to skaffold render --output render.json && gsutil cp render.json <gcs_path>, but I suppose I wouldn't be opposed to supporting it natively in skaffold. our team probably won't be able to prioritize this any time soon, but contributions are always welcome!

@balopat balopat added good first issue Good for newcomers help wanted We would love to have this done, but don't have the bandwidth, need help from contributors labels Apr 15, 2020
@ChrisGe4 ChrisGe4 mentioned this issue Apr 19, 2020
Merged
@dgageot
Copy link
Contributor

dgageot commented Apr 28, 2020

This was fixed with #3979

@dgageot dgageot closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/render good first issue Good for newcomers help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tstromberg @dgageot @balopat @tejal29 @ChrisGe4 @nkubala