Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make on go v1.14: flag provided but not defined: -mod #3699

Closed
tstromberg opened this issue Feb 19, 2020 · 2 comments
Closed

make on go v1.14: flag provided but not defined: -mod #3699

tstromberg opened this issue Feb 19, 2020 · 2 comments
Labels
kind/bug Something isn't working meta/development

Comments

@tstromberg
Copy link
Contributor

If you run make with go go1.14rc1, it errors with:

hack/generate-statik.sh
Installing go-licenses
/var/folders/n1/qxvd9kc11w15mc4qv6g43x80000kt3/T/tmp.wlxi6kFN ~/src/skaffold
go: creating new go.mod: module tmp
flag provided but not defined: -mod
usage: go get [-d] [-t] [-u] [-v] [-insecure] [build flags] [packages]
Run 'go help get' for details.
make: *** [generate-statik] Error 2

This flag was removed in https://go-review.googlesource.com/c/go/+/198438/

@dgageot
Copy link
Contributor

dgageot commented Feb 20, 2020

Thanks @tstromberg for reporting that issue. What about removing that flag once go 1.14 is released and we switch to using it in our development guide and CI/CD?

@dgageot
Copy link
Contributor

dgageot commented Mar 26, 2020

This was fixed with #3775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working meta/development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants