Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold credits produces incorrect output #3428

Closed
corneliusweig opened this issue Dec 22, 2019 · 1 comment · Fixed by #3436
Closed

skaffold credits produces incorrect output #3428

corneliusweig opened this issue Dec 22, 2019 · 1 comment · Fixed by #3436
Assignees
Labels
kind/bug Something isn't working

Comments

@corneliusweig
Copy link
Contributor

Expected behavior

Starting with v1.0.0, skaffold credits produces a folder with all the license files of Skaffold's dependencies. That version produces:

$ skaffold-v1.0.1 credits
$ ls skaffold-credits   
4d63.com  cloud.google.com  github.com  go.opencensus.io  golang.org  google.golang.org  gopkg.in  k8s.io  knative.dev  sigs.k8s.io

Actual behavior

Since v1.1.0, the command produces a folder with the skaffold.yaml schemas instead of the version files:

$ skaffold-v1.1.0 credits
$ ls skaffold-credits
v1.json        v1alpha2.json  v1alpha4.json  v1beta1.json   v1beta11.json  v1beta13.json  v1beta15.json  v1beta17.json  v1beta3.json  v1beta5.json  v1beta7.json  v1beta9.json
v1alpha1.json  v1alpha3.json  v1alpha5.json  v1beta10.json  v1beta12.json  v1beta14.json  v1beta16.json  v1beta2.json   v1beta4.json  v1beta6.json  v1beta8.json  v2alpha1.json

Information

  • Skaffold version: v1.1.0
  • Operating system: linux
@dgageot
Copy link
Contributor

dgageot commented Dec 24, 2019

I might have broken something :-)

@dgageot dgageot self-assigned this Dec 24, 2019
@dgageot dgageot added the kind/bug Something isn't working label Dec 24, 2019
@dgageot dgageot mentioned this issue Dec 24, 2019
2 tasks
dgageot added a commit to dgageot/skaffold that referenced this issue Dec 24, 2019
Generate a single statik.go file that embeds
both credits and schemas.

Fixes GoogleContainerTools#3428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants