Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --XXenableJibInit requirement for "skaffold init" once IDEs are ready #2842

Closed
chanseokoh opened this issue Sep 9, 2019 · 5 comments
Closed

Remove --XXenableJibInit requirement for "skaffold init" once IDEs are ready #2842

chanseokoh opened this issue Sep 9, 2019 · 5 comments
Labels
area/build build/jib kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases

Comments

@chanseokoh
Copy link
Member

chanseokoh commented Sep 9, 2019 •
edited
Loading

skaffold init fails without the flag --XXenableJibInit for a project configured with Jib.

FATA[0000] one or more valid builder configuration (Dockerfile or Jib configuration) must be present to build images with skaffold; please provide at least one build config and try again or run `skaffold init --skip-build`

At some point, we should enable it by default. This should probably need to be coordinated with IDE plugins.

@GoogleContainerTools/java-tools-build
@balopat balopat added area/build priority/p0 Highest priority. We are actively looking at delivering it. kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug. and removed priority/p0 Highest priority. We are actively looking at delivering it. labels Sep 9, 2019
This was referenced Nov 7, 2019
Closed
Closed
@dkirrane
Copy link

dkirrane commented Nov 8, 2019 •
edited
Loading

I get this on skaffold 1.0.0

skaffold init --XXenableJibInit
time="2019-11-08T11:44:40Z" level=fatal msg="one or more valid Kubernetes manifests is required to run skaffold"

Possibly failing because I have my helm chart in the same directory as my pom.xml

@chanseokoh
Copy link
Member Author

chanseokoh commented Nov 8, 2019 •
edited
Loading

@dkirrane I suspect that your error probably happens without --XXenableJibInit too. But even if it only happens with --XXenableJibInit, you should file a new issue. This issue is about removing the -XXenableJibInit flag to make it default. Could you file a new issue?

@tstromberg
Copy link
Contributor

Anyone know if this is still an issue in more recent releases?

@tstromberg tstromberg added priority/p2 May take a couple of releases and removed priority/p1 High impact feature/bug. labels Apr 21, 2020
@nkubala
Copy link
Contributor

nkubala commented Apr 23, 2020

this flag does still exist, but we probably want to remove it soon.

@dgageot
Copy link
Contributor

dgageot commented Jul 1, 2020

Closing in favour of broader #4401

@dgageot dgageot closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build build/jib kind/todo implementation task/epic for the skaffold team priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tstromberg @dgageot @balopat @dkirrane @nkubala @chanseokoh