Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write tests for protobuf generation #2294

Closed
balopat opened this issue Jun 19, 2019 · 1 comment
Closed

write tests for protobuf generation #2294

balopat opened this issue Jun 19, 2019 · 1 comment
Assignees
@dgageot
Labels
area/eventing meta/testing Issues focused on testing Skaffold itself

Comments

@balopat
Copy link
Contributor

balopat commented Jun 19, 2019

We should have tests to ensure that the Event API proto is in sync with the generated grpc code.
Also we should remove the protobufs from codecov.
@balopat balopat added area/eventing meta/testing Issues focused on testing Skaffold itself labels Jun 19, 2019
@balopat balopat mentioned this issue Jun 21, 2019
Merged
@dgageot dgageot mentioned this issue Jul 6, 2019
Merged
@dgageot dgageot self-assigned this Jul 6, 2019
@dgageot
Copy link
Contributor

dgageot commented Jul 8, 2019

Fixed with #2419

@dgageot dgageot closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/eventing meta/testing Issues focused on testing Skaffold itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgageot @balopat