Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce signed binaries #2154

Closed
cmosguy opened this issue May 20, 2019 · 5 comments
Closed

Produce signed binaries #2154

cmosguy opened this issue May 20, 2019 · 5 comments

Comments

@cmosguy
Copy link

cmosguy commented May 20, 2019

Information

  • Skaffold version: latest version
  • Operating system: Windows 10

Steps to reproduce the behavior

  1. Clicked on the link for getting the binary for windows: https://storage.googleapis.com/skaffold/releases/latest/skaffold-windows-amd64.exe

  2. Both the Windows Defender and Symantec Endpoint protection both are prompting me that this .exe can put my system at risk:

image

@nkubala
Copy link
Contributor

nkubala commented May 20, 2019

hmm. I wonder if this is happening because we're not signing the binary when we build it? @dgageot any ideas?

@nkubala nkubala changed the title Getting Started Windows Defender flags skaffold binary May 20, 2019
@balopat balopat self-assigned this May 22, 2019
@balopat
Copy link
Contributor

balopat commented May 22, 2019

I'll have a look at this - we can probably get this sorted out with some internal workflows.

@balopat balopat added kind/feature-request priority/p2 May take a couple of releases labels Aug 14, 2019
@tstromberg
Copy link
Contributor

tstromberg commented Apr 30, 2020

Thank you for the feedback!

I'm closing this issue as it's been open a while, and it is not clear if it's still an open issue. No one has recently stated an interest in addressing this, but if you feel strongly about it, please feel free to add a comment or send us a PR!

@balopat balopat reopened this Jun 24, 2020
@balopat
Copy link
Contributor

balopat commented Jun 24, 2020

This is still an open issue. Nothing has been done about it, I haven't finished setting up a kokoro process for it.

@balopat balopat removed their assignment Jun 29, 2020
@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@briandealwis briandealwis changed the title Windows Defender flags skaffold binary Produce signed binaries Jan 25, 2021
@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
@MarlonGamez
Copy link
Contributor

Closing this issue as we publish signed binaries for windows as of skaffold >= v1.35.1. Please let me know if similar issues are run into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants