Should all Skaffold labels be prefixed with skaffold-?

[dgageot]

Skaffold applies custom labels to every resource that it deploys.

I think that every label that it applies should be prefixed with skaffold- to avoid conflicts with user labels.

[nkubala]

seems like a good idea to me.

[balopat]

+1

[corneliusweig]

Does that count as a breaking change? If so, we would need to label with old and new label name for a transition period, right?

[nkubala]

@corneliusweig good point, unfortunately we don't really have insight into who is using these labels currently or what they're being used for. it would be pretty trivial to keep the old labels around for a while though, so I'd say being safe here doesn't really cost us anything. we could document it in the release notes, and then give a deprecation period (maybe two releases) after which the old labels would disappear.

[tejal29]

except for this one #2045

[corneliusweig]

This issue was fixed with #2062.