Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portName to event api portEvent #1798

Closed
etanshaul opened this issue Mar 14, 2019 · 0 comments · Fixed by #1855
Closed

Add portName to event api portEvent #1798

etanshaul opened this issue Mar 14, 2019 · 0 comments · Fixed by #1855

Comments

@etanshaul
Copy link
Contributor

etanshaul commented Mar 14, 2019

portEvents from the Event API currently look like this:

event {
  portEvent {
    localPort: 5005
    remotePort: 5005
    podName: "skaffold-spring-boot-56df7ff876-65xf8"
    containerName: "skaffold-spring-boot"
    namespace: "default"
  }
}

In order for clients to distinguish between forwarded application ports vs forwarded debug ports, we should add portName to this event (which is prefixed with a debug identifier). This debug identifier will be added to the portName as part of the skaffold debug PR: #1702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants