Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test bug: Cache test depends on global config #1794

Closed
corneliusweig opened this issue Mar 14, 2019 · 1 comment
Closed

test bug: Cache test depends on global config #1794

corneliusweig opened this issue Mar 14, 2019 · 1 comment

Comments

@corneliusweig
Copy link
Contributor

Expected behavior

The test should be independent of any global configuration settings.

Steps to reproduce the behavior

  1. git checkout master
  2. skaffold config set local-cluster -k cluster1 true
  3. go test github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/cache
@corneliusweig corneliusweig changed the title flake: Cache test depends on global config test bug: Cache test depends on global config Mar 14, 2019
@dgageot
Copy link
Contributor

dgageot commented Mar 14, 2019

This was fixed by #1788

@dgageot dgageot closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgageot @corneliusweig