Skip to content

Commit

Permalink
We must handle every profile field type
Browse files Browse the repository at this point in the history
This would have caught #1688

Signed-off-by: David Gageot <[email protected]>
  • Loading branch information
dgageot committed Aug 27, 2019
1 parent 19fbddf commit 5a79118
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/skaffold/schema/profiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ func overlayProfileField(fieldName string, config interface{}, profile interface
}
return v.Interface()
default:
logrus.Warnf("Type mismatch in profile overlay for field '%s' with type %s; falling back to original config values", fieldName, v.Kind())
logrus.Fatalf("Type mismatch in profile overlay for field '%s' with type %s; falling back to original config values", fieldName, v.Kind())
return config
}
}

0 comments on commit 5a79118

Please sign in to comment.