Skip to content

Commit

Permalink
Remove hand written annotated-scaffold.yaml
Browse files Browse the repository at this point in the history
Signed-off-by: David Gageot <[email protected]>
  • Loading branch information
dgageot committed Feb 20, 2019
1 parent 36a0c9f commit 100bb53
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 265 deletions.
2 changes: 1 addition & 1 deletion deprecation-policy.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ A "deprecation event" would coincide with a release.
a.) docs
b.) release notes
c.) command help (if applicable)
d.) annotated-skaffold.yaml (if applicable)
d.) https://skaffold.dev/docs/references/yaml/ (if applicable)

2. if applicable, [from the kubernetes policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli):
> Rule #6: Deprecated CLI elements must emit warnings (optionally disable) when used.
Expand Down
3 changes: 1 addition & 2 deletions docs/content/en/docs/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ read the configuration file from the current directory.
| `deploy` | Specifies how Skaffold deploys artifacts. Skaffold supports using `kubectl`, `helm`, or `kustomize` to deploy artifacts. See [Deployers](/docs/how-tos/deployers) for more information. |
| `profiles`| Profile is a set of settings that, when activated, overrides the current configuration. You can use Profile to override the `build`, `test` and `deploy` sections. |

You can learn more about the syntax of `skaffold.yaml` at
[`skaffold.yaml References`](https://github.com/GoogleContainerTools/skaffold/blob/master/examples/annotated-skaffold.yaml).
You can [learn more](/docs/references/yaml) about the syntax of `skaffold.yaml`.

## Global configuration (~/.skaffold/config)

Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/how-tos/builders/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ controls how Skaffold builds artifacts. To use a specific tool for building
artifacts, add the value representing the tool and options for using the tool
to the `build` section. For a detailed discussion on Skaffold configuration,
see [Skaffold Concepts: Configuration](/docs/concepts/#configuration) and
[skaffold.yaml References](https://github.com/GoogleContainerTools/skaffold/blob/master/examples/annotated-skaffold.yaml).
[skaffold.yaml References](/docs/references/yaml).

## Dockerfile locally with Docker

Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/how-tos/deployers/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ controls how Skaffold builds artifacts. To use a specific tool for deploying
artifacts, add the value representing the tool and options for using the tool
to the `build` section. For a detailed discussion on Skaffold configuration,
see [Skaffold Concepts: Configuration](/docs/concepts/#configuration) and
[Skaffold.yaml References](https://github.com/GoogleContainerTools/skaffold/blob/master/examples/annotated-skaffold.yaml).
[Skaffold.yaml References](/docs/references/yaml).

## Deploying with kubectl

Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/how-tos/profiles/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ environments in your app's lifecycle, like Production or Development.
You can create profiles in the `profiles` section of `skaffold.yaml`. For a
detailed discussion on Skaffold configuration,
see [Skaffold Concepts: Configuration](/docs/concepts/#configuration) and
[skaffold.yaml References](https://github.com/GoogleContainerTools/skaffold/blob/master/examples/annotated-skaffold.yaml).
[skaffold.yaml References](/docs/references/yaml).

## Profiles (`profiles`)

Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/how-tos/taggers/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Tag policy is specified in the `tagPolicy` field of the `build` section of the
Skaffold configuration file, `skaffold.yaml`. For a detailed discussion on
Skaffold configuration,
see [Skaffold Concepts: Configuration](/docs/concepts/#configuration) and
[skaffold.yaml References](https://github.com/GoogleContainerTools/skaffold/blob/master/examples/annotated-skaffold.yaml).
[skaffold.yaml References](/docs/references/yaml).

## `gitCommit`: using Git commit IDs as tags

Expand Down
1 change: 0 additions & 1 deletion hack/new_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ goimports -w pkg/skaffold/schema/${PREV_VERSION}/upgrade*.go
sed -i pkg/skaffold/schema/latest/config.go -e "s;$CURRENT_VERSION;$NEW_VERSION;g"

find integration -name "skaffold.yaml" -print0 | xargs -0 -I xx sed -i xx -e "s;$CURRENT_VERSION;$NEW_VERSION;g"
sed -i integration/examples/annotated-skaffold.yaml -e "s;$CURRENT_VERSION;$NEW_VERSION;g"

sed pkg/skaffold/schema/versions.go -i -e "s;\(.*\)$PREV_VERSION.Version\(.*\)$PREV_VERSION\(.*\);&\n\1$CURRENT_VERSION.Version\2$CURRENT_VERSION\3;g"
sed pkg/skaffold/schema/versions.go -i -e "s;\(.*\)/$PREV_VERSION\(.*\);&\n\1/$CURRENT_VERSION\2;g"
Expand Down
252 changes: 0 additions & 252 deletions integration/examples/annotated-skaffold.yaml

This file was deleted.

5 changes: 0 additions & 5 deletions integration/run_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,6 @@ func TestRun(t *testing.T) {
description: "microservices",
dir: "examples/microservices",
deployments: []string{"leeroy-app", "leeroy-web"},
}, {
description: "annotated-skaffold",
dir: "examples",
filename: "annotated-skaffold.yaml",
pods: []string{"getting-started"},
}, {
description: "envTagger",
dir: "examples/tagging-with-environment-variables",
Expand Down

0 comments on commit 100bb53

Please sign in to comment.