Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to HTTP on right condition when HttpHostConnectException #771

Merged
merged 7 commits into from
Aug 2, 2018

Conversation

chanseokoh
Copy link
Member

Fixes #767.

I think it makes sense to me to fall back to HTTP only when certain conditions are met: #767 (comment)

Does it make sense?

Copy link
Contributor

@coollog coollog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - although I'm wondering if there will be many repeated warning messages for someone trying to use an HTTP registry.

@chanseokoh
Copy link
Member Author

Looks good - although I'm wondering if there will be many repeated warning messages for someone trying to use an HTTP registry.

That's a valid point. We could add a counter somewhere to print only a limited number of repeated warnings. But I don't think I'd like to add that feature now. I'd think it's a small price to pay for using insecure servers. However, I'll file an issue so that we can discuss.

@chanseokoh chanseokoh merged commit be01e2a into master Aug 2, 2018
@chanseokoh chanseokoh deleted the i767-http-fallback branch August 2, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants