Add build steps for building tarball #567
Conversation
|
|
||
| @Override | ||
| public Void call() throws ExecutionException, InterruptedException { | ||
| ImmutableList.Builder<ListenableFuture<?>> dependenciesBuilder = ImmutableList.builder(); |
There was a problem hiding this comment.
Aside: we should probably figure out a good way to organize all the duplications of the code like this in all the steps.
|
|
||
| // Build the image to a tarball | ||
| buildConfiguration.getBuildLogger().lifecycle("Building image to tar file..."); | ||
| if (Files.exists(outputPath.getParent())) { |
There was a problem hiding this comment.
What is this doing? If the file exists, wouldn't createDirectories not do anything?
There was a problem hiding this comment.
I added it just in case because I wasn't sure - I should really get into the habit of reading documentation on methods I'm not 100% sure of.
There was a problem hiding this comment.
Ah wait now I know why I did it - createDirectory throws an exception if the directory exists, createDirectories doesn't. So I guess I got the two mixed up.
|
|
||
| // Build the image to a tarball | ||
| buildConfiguration.getBuildLogger().lifecycle("Building image to tar file..."); | ||
| Files.createDirectories(outputPath.getParent()); |
There was a problem hiding this comment.
Do we want to be generating all the parent directories though? Perhaps we should only generate the file in an existing directory?
There was a problem hiding this comment.
In our use case, yes, the directory should already exist since we're putting it in the build output. But I imagine if this were eventually configurable (which I guess it already is from the library perspective), then it'd be a better experience to generate all the directories the user specifies rather than throwing an exception if the directory structure isn't already setup.
Part of #514