Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds extra layer with contents of src/main/jib. #562

Merged
merged 6 commits into from
Jul 11, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Jul 11, 2018

This might be what we go with for #473 over what was proposed at #455.

This PR just has the changes for the Gradle plugin. Docker context exporting is also not supported yet.

@coollog coollog requested a review from a team July 11, 2018 19:44
Copy link
Contributor

@TadCordle TadCordle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make an issue for the docker context todo

@TadCordle
Copy link
Contributor

Also would this close this old issue? #213

@coollog
Copy link
Contributor Author

coollog commented Jul 11, 2018

@TadCordle yea, though I'll close it manually after the Maven one is added too

@coollog coollog added this to the 0.9.5 milestone Jul 11, 2018
@coollog coollog merged commit bdb2bfb into master Jul 11, 2018
@coollog coollog deleted the extra-files-directory branch July 11, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants