Rename BuildTarballAndLoadDockerStep to LoadDockerStep #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadCordle
requested review from
briandealwis,
loosebazooka,
coollog and
chanseokoh
briandealwis
approved these changes
Jul 11, 2018
| @@ -208,7 +208,7 @@ public void waitOnPushImageStep() throws ExecutionException, InterruptedExceptio | |||
|
|
|||
| public void waitOnBuildTarballAndLoadDockerStep() | |||
There was a problem hiding this comment.
And same again. (this was meant to reference #559 (comment))
| @@ -192,8 +192,8 @@ public StepsRunner runPushImageStep() { | |||
| } | |||
|
|
|||
| public StepsRunner runBuildTarballAndLoadDockerStep() { | |||
There was a problem hiding this comment.
Should this method be renamed? Hmm, I guess not as it will need to build the tarball when that is separated.
There was a problem hiding this comment.
Yeah good catch, this should probably be renamed. We ended up agreeing on just creating a separate step instead of splitting this one up - #502 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small part of #514