-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also looks for registry credential files in XDG folders #3532
Also looks for registry credential files in XDG folders #3532
Conversation
@sv3ndk Thank you for your contribution, really appreciate it. The team will review this after the holidays. |
Thanks for the kind feed-back. Enjoy the holidays :) |
You too. Happy Holidays! |
Hi @ddixit14 , I pushed a commit to fix the formatting issues, could you please re-trigger the CI workflow? |
Sorry, I'm realizing there was one remaining formatting issue that |
df403f0
to
49b585c
Compare
Thanks for your contribution. I'm going to merge this once the tests pass, unless I hear back any concerns from you. |
Kudos, SonarCloud Quality Gate passed! |
This PR is my proposition for addressing #3524 . This is my first contribution to this project, don't hesitate to let me know if I failed to follow any convention.
This PR adds 2 locations, based on the XDG base directory specification, to the list of places where Jib looks for a credential file for registry authentication.
The main motivation for this change is enabling to use Jib together with Podman.
The 2 added locations are also mentioned in
man containers-auth.json
:This logic seems aligned with the philosophy of Jib, which already iterates through various locations.
Jib also already follows XDG specification, for example for storing its own config.
The resulting flow should hopefully be natural to most users: both Docker and Podman users would have their credential file picked up automatically in the default location of their tool.
I updated documentation to mention the new configuration feature.