Fix class cast exception in gradle plugin main class detection logic #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpichler
force-pushed
the
bugfix/class-cast-exception-gradle-main-class
branch
from
01f556e to
fe8876c
Compare
chanseokoh
reviewed
Aug 18, 2021
|
I've added a note to the change log :) |
patrickpichler
force-pushed
the
bugfix/class-cast-exception-gradle-main-class
branch
2 times, most recently
from
b2de760 to
93a052f
Compare
The main class detection logic in the gradle plugin always assumed that the `Main-Class` attribute, set in the main jar task, is a string. This is not always true, as it sometimes makes sense to set it to a provider of String in order to link multiple configurations together. The logic now tests the class of the value returned for the `Main-Class` attribute and in case of an `Provider<?>` value, it will call the `get` method. If the provider is not set, this will cause the task to fail. The resulting object is then transformed to a String. fixes GoogleContainerTools#3396
chanseokoh
reviewed
Aug 18, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main class detection logic in the gradle plugin always assumed that
the
Main-Classattribute, set in the main jar task, is a string. Thisis not always true, as it sometimes makes sense to set it to a provider
of String in order to link multiple configurations together.
The logic now tests the class of the value returned for the
Main-Classattribute and in case of an
Provider<?>value, it will call thegetmethod. If the provider is not set, this will cause the task to fail.
The resulting object is then transformed to a String.
fixes #3396