Cleanups and fixes #3178
Merged
Cleanups and fixes #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
=========================================
Coverage 71.18% 71.18%
Complexity 2331 2331
=========================================
Files 279 279
Lines 9846 9846
Branches 990 990
=========================================
Hits 7009 7009
Misses 2491 2491
Partials 346 346 Continue to review full report at Codecov.
|
mpeddada1
reviewed
Apr 1, 2021
...rc/integration-test/java/com/google/cloud/tools/jib/maven/BuildImageMojoIntegrationTest.java
Show resolved
Hide resolved
mpeddada1
approved these changes
Apr 1, 2021
mpeddada1
reviewed
Apr 1, 2021
...rc/integration-test/java/com/google/cloud/tools/jib/gradle/SingleProjectIntegrationTest.java
Show resolved
Hide resolved
mpeddada1
reviewed
Apr 1, 2021
jib-gradle-plugin/src/integration-test/java/com/google/cloud/tools/jib/gradle/JibRunHelper.java
Outdated
Show resolved
Hide resolved
mpeddada1
reviewed
Apr 1, 2021
| @@ -189,7 +190,8 @@ static Instant getCreationTime(String imageReference) throws IOException, Interr | |||
| return Instant.parse(inspect); | |||
| } | |||
|
|
|||
| static void assertImageDigestAndId(Path projectRoot) throws IOException, DigestException { | |||
| static void assertValidImageDigestAndIdOutputFiles(Path projectRoot) | |||
There was a problem hiding this comment.
hm how about assertThatExpectedImageDigestAndIdReturned?
mpeddada1
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized the assertion should have been
isGreaterThanin #3176.