-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<includes> and <excludes> filtering feature for extraDirectories #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3173 +/- ##
============================================
+ Coverage 71.15% 71.18% +0.03%
- Complexity 2323 2331 +8
============================================
Files 279 279
Lines 9835 9846 +11
Branches 989 990 +1
============================================
+ Hits 6998 7009 +11
Misses 2491 2491
Partials 346 346
Continue to review full report at Codecov.
|
mpeddada1
reviewed
Mar 31, 2021
...mmon/src/main/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelper.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelper.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelper.java
Show resolved
Hide resolved
...mmon/src/main/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelper.java
Show resolved
Hide resolved
mpeddada1
approved these changes
Mar 31, 2021
.../src/test/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelperTest.java
Show resolved
Hide resolved
...mmon/src/main/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelper.java
Show resolved
Hide resolved
...mmon/src/main/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelper.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #3171. Review it first.Fixes #2564 (and #3164).
The idea is to allow glob patterns that works similar to how
maven-resources-plugin
works. This makes adding a single file easy as well.In a follow-up PR, I'll add integration tests for Maven and Gradle and update CHANGELOG.