Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inclusion/exclusion filtering configuration for ExtraDirectories in Maven and Gradle #3171

Merged
merged 14 commits into from
Mar 31, 2021

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Mar 29, 2021

Adds new "includes" and "excludes" config parameters in Maven and Gradle.

Previously, RawConfiguration returned a map (for <from> --> <into>), but since now it requires two more fields, we should return a structure.

Toward #2564 (and #3164).

@google-cla google-cla bot added the cla: yes label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #3171 (a813c0e) into master (c2cc436) will increase coverage by 0.01%.
The diff coverage is 64.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3171      +/-   ##
============================================
+ Coverage     71.14%   71.15%   +0.01%     
- Complexity     2322     2323       +1     
============================================
  Files           279      279              
  Lines          9831     9835       +4     
  Branches        991      989       -2     
============================================
+ Hits           6994     6998       +4     
  Misses         2491     2491              
  Partials        346      346              
Impacted Files Coverage Δ Complexity Δ
...cloud/tools/jib/gradle/GradleRawConfiguration.java 55.81% <0.00%> (+2.48%) 22.00 <0.00> (ø)
...e/cloud/tools/jib/maven/MavenRawConfiguration.java 51.28% <0.00%> (+4.77%) 18.00 <0.00> (ø)
...oud/tools/jib/gradle/ExtraDirectoryParameters.java 77.27% <50.00%> (-16.85%) 6.00 <1.00> (+1.00) ⬇️
.../cloud/tools/jib/maven/JibPluginConfiguration.java 67.60% <60.00%> (-0.29%) 54.00 <0.00> (ø)
...b/plugins/common/PluginConfigurationProcessor.java 63.87% <75.00%> (ø) 65.00 <0.00> (ø)
...d/tools/jib/gradle/ExtraDirectoriesParameters.java 89.18% <100.00%> (+0.30%) 11.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cc436...a813c0e. Read the comment docs.

@chanseokoh chanseokoh changed the title [Draft] inclusion/exclusion filtering feature for ExtraDirectories Add inclusion/exclusion filtering configuration for ExtraDirectories in Maven and Gradle Mar 30, 2021
@chanseokoh chanseokoh marked this pull request as ready for review March 30, 2021 15:33
@chanseokoh
Copy link
Member Author

Ready for review. This only adds new configuration options.

@chanseokoh chanseokoh merged commit 1ea37ee into master Mar 31, 2021
@chanseokoh chanseokoh deleted the extra-directories-filtering branch March 31, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants