-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inclusion/exclusion filtering configuration for ExtraDirectories in Maven and Gradle #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3171 +/- ##
============================================
+ Coverage 71.14% 71.15% +0.01%
- Complexity 2322 2323 +1
============================================
Files 279 279
Lines 9831 9835 +4
Branches 991 989 -2
============================================
+ Hits 6994 6998 +4
Misses 2491 2491
Partials 346 346
Continue to review full report at Codecov.
|
chanseokoh
changed the title
[Draft] inclusion/exclusion filtering feature for ExtraDirectories
Add inclusion/exclusion filtering configuration for ExtraDirectories in Maven and Gradle
Mar 30, 2021
Ready for review. This only adds new configuration options. |
mpeddada1
approved these changes
Mar 31, 2021
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new "includes" and "excludes" config parameters in Maven and Gradle.
Previously,
RawConfiguration
returned a map (for<from>
--><into>
), but since now it requires two more fields, we should return a structure.Toward #2564 (and #3164).