-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cyan coloring in build output when --console=plain
is used.
#2764
Comments
Affects both Maven and Gradle. Doesn't matter if it's We should also clean up code that we introduced in String cleanOutput = output.replace("\u001B[36m", "").replace("\u001B[0m", ""); Details: #2739 (comment) There may be more places where we color output. |
Any updates here? Thanks EDIT: |
It's a low priority although I think it's an easy fix. We're pretty overloaded, and we'd appreciate contributions. 😄 |
Thanks for the update! In the meantime, I was able to work around it using
|
@chanseokoh I would like to take this. jib/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/GradleProjectProperties.java Line 339 in 9f4c93c
or if there is any way to access ConsoleOutput from jib/jib-plugins-common/src/main/java/com/google/cloud/tools/jib/plugins/common/JibBuildRunner.java Line 76 in 9f4c93c
?? |
Hey @vinod-tahelyani, thanks for looking into this! We were thinking that this change could be even more effective if there was a way to filter out any color (not just cyan) in the PlainConsoleLogger? This would allow us to touch all parts of the code that use the plain console output. Looking at this stackoverflow link, it seems like most colors follow a similar regex pattern. |
Reopening to track the cleanup task: #2764 (comment) |
No description provided.
The text was updated successfully, but these errors were encountered: