Fix Azure auth failure from not using identity token in docker.config auths section #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jib-core/src/main/java/com/google/cloud/tools/jib/registry/credentials/DockerConfig.java
Show resolved
Hide resolved
| @@ -138,15 +139,25 @@ public Path getDockerConfigFile() { | |||
| } | |||
|
|
|||
| // Lastly, find defined auth. | |||
| String auth = dockerConfig.getAuthFor(registryAlias); | |||
| AuthTemplate auth = dockerConfig.getAuthFor(registryAlias); | |||
| if (auth != null) { | |||
There was a problem hiding this comment.
then we check if present here?
Maybe not only an issue with Azure. But because we've not heard any error report, I think it's safer to keep using |
loosebazooka
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2488.