-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize insecure registry failover by caching failover history #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver-history-final
This is now ready for review. |
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Outdated
Show resolved
Hide resolved
Huh, this branch isn't really the one that I originally intended to put up. Somehow I see some commit is lost. The |
TadCordle
reviewed
Nov 13, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Show resolved
Hide resolved
TadCordle
approved these changes
Nov 13, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/http/FailoverHttpClient.java
Show resolved
Hide resolved
Oh and changelog, haha |
loosebazooka
approved these changes
Nov 14, 2019
We can probably put this out with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946.
Significantly cuts the number of HTTP registry connections, by more than half in my testing from 528 to 248. Once a failover occurs for a registry host, it is not repeated (down to 4 from 127 as shown below).
In practice, however, due to Jib's concurrent connections, it may repeat the failover for the same host but mostly only once or twice.
Increases the failover log level from INFO to WARNING.