Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin configuration for local base images #1930

Merged
merged 30 commits into from
Sep 5, 2019
Merged

Add plugin configuration for local base images #1930

merged 30 commits into from
Sep 5, 2019

Conversation

TadCordle
Copy link
Contributor

@TadCordle TadCordle commented Aug 26, 2019 •
edited
Loading

Fixes #1468, fixes #1905.

Adds plugin configuration for different base image types. New configurations:

  • registry://ima.ge/name to use a registry image at ima.ge/name
  • docker://imagename to use a Docker daemon image named imagename
  • tar:///path/to/tar.tar to use an image tarball in the filesystem at path /path/to/tar.tar

@TadCordle TadCordle changed the title Local base image plugins Add plugin configuration for local base images Aug 26, 2019
@TadCordle TadCordle requested a review from a team August 28, 2019 14:17
@TadCordle TadCordle requested a review from a team September 3, 2019 17:53
chanseokoh
chanseokoh reviewed Sep 3, 2019
View reviewed changes
@TadCordle
Copy link
Contributor Author

Going to add registry:// back in given recent chat.

chanseokoh
chanseokoh reviewed Sep 4, 2019
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take another look later.

chanseokoh
chanseokoh approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run gradlew integrationTest locally before merging.

@TadCordle TadCordle merged commit 5a4b6e4 into master Sep 5, 2019
@TadCordle TadCordle deleted the local-base-image-plugins branch September 5, 2019 14:34
@chanseokoh chanseokoh mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis left review comments

@loosebazooka loosebazooka loosebazooka left review comments

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow using saved images (tar balls) as base images Support for using a local Docker cache for base images
5 participants
@TadCordle @briandealwis @loosebazooka @chanseokoh @googlebot