add v2.2 manifest list template #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
loosebazooka
force-pushed
the
manifestList
branch
from
86dadfe to
0e95693
Compare
loosebazooka
force-pushed
the
manifestList
branch
from
0e95693 to
b9730d5
Compare
TadCordle
reviewed
Jun 24, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jun 24, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jun 24, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/V22ManifestListTemplate.java
Outdated
Show resolved
Hide resolved
TadCordle
approved these changes
Jun 24, 2019
| * configuration. | ||
| * | ||
| * @see <a href="https://github.com/opencontainers/image-spec/blob/master/descriptor.md">OCI | ||
| * Content Descriptors</a> |
There was a problem hiding this comment.
Sorry, I'm late to the party, but this link seems out of place since is a docker manifest list?
(If it is equally applicable to an OCI Image Index, maybe it should be broken out as a separate class?)
There was a problem hiding this comment.
Uh this javadoc needs to be cleaned up. Oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1567