Add some documentation for the Spring Boot WAR support #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
reviewed
Jun 20, 2019
| @@ -415,6 +415,8 @@ jib { | |||
| } | |||
| ``` | |||
|
|
|||
| If you are using Spring Boot in your war project, make sure to [create a deployable war file](https://docs.spring.io/spring-boot/docs/2.1.x/reference/html/howto-traditional-deployment.html#howto-create-a-deployable-war-file). (Extending from `SpringBootServletInitializer` and declaring the embedded container as provided) | |||
There was a problem hiding this comment.
Hmm... do you think this helps? Although Spring Boot is really popular, I think we don't generally want to explain in Jib docs some detailed instructions on how to create a WAR using various web frameworks. Explaining how to create a deployable WAR doesn't seem helpful for understanding how to use Jib for WAR projects. If there's something necessary to say to use Jib in case of a Spring Boot WAR project, we can definitely add it here, but I don't really see something special in this update.
There was a problem hiding this comment.
Agreed, I feel like something like this would be better suited in the FAQ or something than in the README, if anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1797 #1787 #1786