Use bootWar instead of war for Spring Boot war projects #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsgrefer
force-pushed
the
feature/bootWar
branch
from
15cb700 to
4d1bd2b
Compare
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/TaskCommon.java
Show resolved
Hide resolved
chanseokoh
reviewed
Jun 20, 2019
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/TaskCommon.java
Outdated
Show resolved
Hide resolved
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/TaskCommon.java
Show resolved
Hide resolved
chanseokoh
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Looks like you have to resolve merge conflicts since I merged #1788.
| @@ -70,6 +70,7 @@ dependencies { | |||
| testCompile 'junit:junit:4.12' | |||
| testCompile 'org.mockito:mockito-core:2.23.4' | |||
| testCompile 'org.slf4j:slf4j-api:1.7.25' | |||
| testCompile 'org.springframework.boot:spring-boot-gradle-plugin:2.1.6.RELEASE' | |||
There was a problem hiding this comment.
Let's add a comment
// only for testing a concrete Spring Boot example in a test (not for test infrastructure)
There was a problem hiding this comment.
You have write access to this branch of my fork of jib. So you can do such small changes directly.
|
I've resolved the merge conflicts and added the comment. |
chanseokoh
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1786