Add support for docker.io #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
reviewed
Mar 18, 2019
| @@ -236,12 +237,12 @@ private ImageReference(String registry, String repository, String tag) { | |||
| } | |||
|
|
|||
| /** | |||
| * Gets the registry portion of the {@link ImageReference}. | |||
| * Gets the registry host of the {@link ImageReference}. | |||
There was a problem hiding this comment.
What are the consequences of this? That is, I hope jib:dockerBuild will push docker.io/some/name instead of registry-1.docker.io/some/name.
Also, should RegistryAliasGroup.getHost() be done outside of this? The getters of this class simply returns its fields as-is, and we may want to keep it that way, as an immutable class and a pure representation of the parsed reference.
There was a problem hiding this comment.
That is a good question! I did this so that ImageReference#toString() would preserve the docker.io prefix.
With this change, jib:dockerBuild -Dimage=docker.io/foo/bar/baz records the image as foo/bar/baz. But jib:buildTar -Dimage=docker.io/foo/bar/baz records the repoTag as docker.io/foo/bar/baz.
But if I do a docker build -t docker.io/foo/bar/baz ., docker reports the built image without the docker.io prefix. And the result of docker save docker.io/foo/bar/baz doesn't have docker.io either.
I'll move this remapping into parse().
TadCordle
reviewed
Mar 18, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/event/events/LogEvent.java
Outdated
Show resolved
Hide resolved
chanseokoh
approved these changes
Mar 18, 2019
TadCordle
approved these changes
Mar 18, 2019
|
Kokoro-macos build failure occurred when the wrapper tried to download the gradle instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1549
RegistryAliasGroupto manage registry → host mappings.ImageReference#getRegistry()to remap the registry; this class does other mappings, likelibrary/prefixing of the repository.registry-1.docker.iodocker.ioandregistry-1.docker.ioto the Docker Hub registry aliases inRegistryAliasGroup- add atoString()toLogEventto help track down a spurious test error!