Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Docker context generator #1264

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

TadCordle
Copy link
Contributor

@TadCordle TadCordle commented Nov 20, 2018

Fixes #1219, since that's what the issue is about
Fixes #1241, fixes #1010, fixes #913, fixes #493 since those will be obsolete

@loosebazooka
Copy link
Member

@TadCordle can you set up that PR (in parallel to this) with alternative options for

  1. An optimized application dockerfile
  • maybe a link to that project that generates dockerfiles
  1. Ways to inspect the image

These can be super short: It's not really our project's goal to do this.

@chanseokoh
Copy link
Member

chanseokoh commented Nov 20, 2018

For manual inspection, I find dive complete and comprehensive: https://github.com/wagoodman/dive Extremely versatile and feature-rich interactive tool to inspect files in each layer.

Not that we should promote it. I guess the tool is from some random developer.

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@TadCordle TadCordle merged commit 882c85b into master Nov 20, 2018
@TadCordle TadCordle deleted the i1219-remove-docker-context branch November 20, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants