Add system properties for gradle config #1087
Conversation
TadCordle
requested review from
briandealwis,
loosebazooka,
coollog and
chanseokoh
| package com.google.cloud.tools.jib.gradle; | ||
|
|
||
| /** Names of system properties used to set configuration via commandline. */ | ||
| class PropertyNames { |
There was a problem hiding this comment.
These are the same as the Maven ones right? Let's put them in plugins-common?
There was a problem hiding this comment.
Also, what do you think about using an enum for this?
There was a problem hiding this comment.
I think they could go in plugins-common, although I thought we were keeping configuration naming out of plugins-common for some reason (maybe I'm misremembering a conversation we had a while ago, might have been something else).
I don't think we should use an enum here since this is specifically a collection of string constants, not a special data type. Although, maybe we could call "system property name" a special type of string. I don't think it's necessary though, since all we'll ever be doing is using the string values anyway.
Fixes #1083.
Adds system properties to allow configuring gradle parameters via command-line. Same format as maven in #1080.