Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty image cache metadata #799

Closed
chanseokoh opened this issue Aug 6, 2018 · 4 comments
Closed

Empty image cache metadata #799

chanseokoh opened this issue Aug 6, 2018 · 4 comments
Milestone

Comments

@chanseokoh
Copy link
Member

#534 (comment)

It's worth an investigation. Even if this happens only when there is a problem interacting with a registry, we should be able to have a correct cache metadata locally.

@coollog
Copy link
Contributor

coollog commented Aug 6, 2018

This is due to the build failing at the manifest push step, whereas cache metadata is currently written after build steps succeed. To resolve this, we would need to either

  1. Change cache metadata to be independent for each layer so that each can be written independently and during their respective build steps, or
  2. Catch any failures during the build steps and write the cache metadata upon failure as well

I prefer approach 1) since it is more robust and less prone to possible cache corruption.

@Hi-Fi
Copy link

Hi-Fi commented Aug 8, 2018

Reason I tried to check the cache was to see what kind of Manifest Jib tries to send (and compare it to one that's obtained from Artifactory/Red Hat Container Registry).

@chanseokoh
Copy link
Member Author

@Hi-Fi FYI, the Jib cache metadata is just an Jib-internal data structure and has nothing to do with files actually used for the Docker or OCI image format.

@coollog coollog modified the milestones: v0.9.10, v0.9.11 Aug 9, 2018
@coollog
Copy link
Contributor

coollog commented Aug 29, 2018

This will be fixed by the new cache mechanism #878

@coollog coollog closed this as completed Aug 29, 2018
@coollog coollog modified the milestones: v0.9.11, v0.11.0 Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants