Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear and non-ambiguous maven properties to the maven plugin #728

Closed
victornoel opened this issue Jul 27, 2018 · 5 comments
Closed

Add clear and non-ambiguous maven properties to the maven plugin #728

victornoel opened this issue Jul 27, 2018 · 5 comments
Assignees
Milestone

Comments

@victornoel
Copy link

When using Maven, often one wants to pass some of the plugin configuration via properties (-DmyProp).

Currently it seems some of the configuration are available via properties but:

  • it's not documented anywhere (usually plugins have each configuration mapped to an expression that is resolved by maven, and it appears in plugin doc as well as in IDE)
  • it's not clear if things like credHelper, if it is available as a property, is going to be applied to to, from or both.

It would be great if all the configuration could be specified via properties named like jib.to.credHelper and so on.

@coollog
Copy link
Contributor

coollog commented Jul 27, 2018

Hi @victornoel , thanks for the feature suggestion! We don't actually have any configuration available via properties except for the target image (via the image shorthand). We'll definitely look at adding properties to configure other configuration as well @GoogleContainerTools/java-tools .

@chanseokoh
Copy link
Member

chanseokoh commented Jul 27, 2018

It would be great if all the configuration could be specified via properties named like jib.to.credHelper and so on.

What you can do in the meantime is like this:

  <properties>
    <jib.to.credHelper>my-default-cred-helper</jib.to.credHelper>
  </properties>
      <plugin>
        <groupId>com.google.cloud.tools</groupId>
        <artifactId>jib-maven-plugin</artifactId>
        <version>0.9.7</version>
        <configuration>
          <to>
            <image> ... </image>
            <credHelper>${jib.to.credHelper}</credHelper>
          </to>
        </configuration>

Then you can do, e.g., mvn -Djib.to.credHelper=docker jib:build.

@victornoel
Copy link
Author

@chanseokoh that's exactly what I'm doing right now, so I think that we can make this feature request kind of low prio but nice to have :)

@coollog
Copy link
Contributor

coollog commented Nov 9, 2018

Hi @victornoel , we've released version 0.10.0 with system properties to define any of Jib's configuration.

@victornoel
Copy link
Author

@coollog hey thanks for the heads up! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants