-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clear and non-ambiguous maven properties to the maven plugin #728
Comments
Hi @victornoel , thanks for the feature suggestion! We don't actually have any configuration available via properties except for the target image (via the |
What you can do in the meantime is like this: <properties>
<jib.to.credHelper>my-default-cred-helper</jib.to.credHelper>
</properties> <plugin>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<version>0.9.7</version>
<configuration>
<to>
<image> ... </image>
<credHelper>${jib.to.credHelper}</credHelper>
</to>
</configuration> Then you can do, e.g., |
@chanseokoh that's exactly what I'm doing right now, so I think that we can make this feature request kind of low prio but nice to have :) |
Hi @victornoel , we've released version |
@coollog hey thanks for the heads up! 👍 |
When using Maven, often one wants to pass some of the plugin configuration via properties (
-DmyProp
).Currently it seems some of the configuration are available via properties but:
expression
that is resolved by maven, and it appears in plugin doc as well as in IDE)credHelper
, if it is available as a property, is going to be applied toto
,from
or both.It would be great if all the configuration could be specified via properties named like
jib.to.credHelper
and so on.The text was updated successfully, but these errors were encountered: