Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support username and password tokens from dockercfg auths #3364

Closed
tpokki opened this issue Aug 2, 2021 · 4 comments
Closed

Support username and password tokens from dockercfg auths #3364

tpokki opened this issue Aug 2, 2021 · 4 comments

Comments

@tpokki
Copy link
Contributor

tpokki commented Aug 2, 2021

Environment:

  • Jib version: 3.1.2
  • Build tool: maven 3.6.3
  • OS: macOS

Description of the issue:
Jib is missing support for username and password fields in dockercfg auths block.
Example

{
  "auths": {
      "registry.example.com": {
           "username": "someuser",
           "password": "somepw"
       }
}

Expected behavior:
Jib to pick up username and password fields from dockercfg (and not just credHelper and auth).

Steps to reproduce:

  1. Add username and password for your registry into your config.json as described above
  2. Build
  3. Jib does not pick up username and password

Additional Information:

I have implemented the necessary changes to add support in here:
tpokki@479a5df

If you approve, I'll create PR.

Thanks,
Toni

@chanseokoh
Copy link
Member

I think this is great. Create a PR (with a test), and we'll review it. Thanks a lot!

@chanseokoh
Copy link
Member

Fixed by #3365.

@chanseokoh
Copy link
Member

@tpokki we released Jib plugins 3.1.4 with the fix.

@chanseokoh
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants