-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable adding new tags to existing images #2360
Comments
Could you help clarify what you mean by new tags? Presumably if your tag is not dynamically generated this shouldn't be happening? |
Yes, the tags are dynamically generated and their value changes for every build. This is a typical build we have: some microservices have changes and others no. A new tag is generated, and each service is built. As it is, Jib will:
We would like to disable (2), ie, not add tags to existing images. |
So a couple of things here.
I think there might be some scope for adding this feature as a flag/config option, but I'm not sure yet. |
|
Thanks @karlmuscat-dpg this is useful information. If you're interested in submitting a design/proposal for this that we can work on together that could speed up the process -- https://github.com/GoogleContainerTools/jib/tree/master/proposals I would start off with something less formal, like a range of ideas and we can narrow down what might work in the comments. If that is not an option for you, someone on the jib dev team can take a look at some point in the (hopefully near) future. |
Sure. I'll give it a shot. |
@loosebazooka PR 2382 👍 |
@loosebazooka @chanseokoh Pushed PR #2531 to resolve this issue |
@karlmuscat @karlmuscat-dpg Jib Gradle 2.5.0 and Jib Maven 2.5.2 are released with the feature. Thanks for your contribution! Try it out, and let us know if it works. |
hey @chanseokoh! upgraded to 2.5.0, set the env var, and works like a charm 👍 thanks a lot |
Is there a way how to disable adding new tags to existing images?
We have a monorepo with multiple microservices, and for every build, we create a new tag. We would like to tag only those services that generate new images. Other services that have no changes (hence, their images have the same digest) do not need to get new tags.
The text was updated successfully, but these errors were encountered: