Allow more timezone formats #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
reviewed
Mar 9, 2020
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Show resolved
Hide resolved
loosebazooka
commented
Mar 9, 2020
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Mar 9, 2020
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessorTest.java
Show resolved
Hide resolved
...rc/test/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessorTest.java
Outdated
Show resolved
Hide resolved
chanseokoh
approved these changes
Mar 10, 2020
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Show resolved
Hide resolved
|
I will update the changelog too |
chanseokoh
reviewed
Mar 12, 2020
jib-gradle-plugin/CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. | |||
| ### Added | |||
|
|
|||
| ### Changed | |||
| - `jib.container.creationTime` now accepts more timezone formats:`Z`,`+HHmm`. ([#2320](https://github.com/GoogleContainerTools/jib/issues/2260)) | |||
There was a problem hiding this comment.
I believe Z was already accepted. So, "accepts a timezone format without colon: +HHmm"? And if this improves usability with git, worth nothing that? Like, "This helps use git commit timestamp from git ... or some git timestamp plugin"?
There was a problem hiding this comment.
Oh, the issue number in issues/2260 is wrong.
There was a problem hiding this comment.
nit: also add a space after ### Changed. I saw we have the same problem in line 15, so can you add a space after ### Added there too?
chanseokoh
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2319