-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with a TarImage fails if the tar does not contain explicit directory entries #2067
Comments
@TadCordle if I remember correctly, |
The fix shouldn't change anything for tars that have explicit directory entries, so yes, this will continue to work fine for Edit: Integration tests pass with the fix. |
Hi @TadCordle, your PR branch works perfectly in my project. Thanks very much! |
@Zetten we've released jib-core 0.12.0 with this fix. |
Environment:
Description of the issue:
Jib cannot containerize or use as a base an image tar file built by Bazel's rules_docker. Because the tar file does not contain explicit entries for the directory structure (i.e. the file
<hash>/VERSION
is declared, but not the directory<hash>/
), Jib's TarExtractor fails when trying to copy to its temporary extract path any TarEntry files which are in subdirectories.Expected behavior:
Jib Core is able to unpack and work with layers from a tar built by Bazel.
Steps to reproduce:
bazel build :test_image.tar
Jib.from(TarImage.at(testImage)).containerize(...)
Log output:
Example from a test:
Additional Information:
I have a naive fix locally, which solves the issue: Zetten@426b5a3
The text was updated successfully, but these errors were encountered: