Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum instead of Optional<Boolean> for tri-state PreparedLayer.existsInTarget #1867

Closed
chanseokoh opened this issue Jul 23, 2019 · 0 comments · Fixed by #1879
Closed

Use enum instead of Optional<Boolean> for tri-state PreparedLayer.existsInTarget #1867

chanseokoh opened this issue Jul 23, 2019 · 0 comments · Fixed by #1879
Assignees
@chanseokoh
Labels
cleanup

Comments

@chanseokoh
Copy link
Member

From #1840 (comment)

Currently

  • Optional.empty --> existence unknown
  • true Optional --> layer exists in the target registry
  • false Optional --> conclusively doesn't exist

Using enum should be more readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chanseokoh chanseokoh

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tri-state enum for blob existence in target repository GoogleContainerTools/jib
1 participant
@chanseokoh