Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JavaContainerBuilder in plugins #1373

Closed
TadCordle opened this issue Dec 20, 2018 · 3 comments
Closed

Use JavaContainerBuilder in plugins #1373

TadCordle opened this issue Dec 20, 2018 · 3 comments
Assignees
@TadCordle
Milestone
v0.2.0-core

Comments

@TadCordle
Copy link
Contributor

Followup to #1347
@TadCordle TadCordle self-assigned this Dec 20, 2018
@coollog coollog added this to the v0.2.0-core milestone Dec 20, 2018
@chanseokoh
Copy link
Member

Hmm... if we really want to do this, I think we will need more changes to JavaContianerBuilder? For example, we cannot create an extra files layer with it.

@TadCordle
Copy link
Contributor Author

TadCordle commented Dec 20, 2018 •
edited
Loading

We can call toContainerBuilder() and add layers to that, can't we?

@chanseokoh
Copy link
Member

Ah, it returns JibContainerBuilder. I missed that.

This was referenced Mar 13, 2019
Merged
Merged
@chanseokoh chanseokoh mentioned this issue Mar 20, 2019
Closed
@TadCordle TadCordle mentioned this issue Mar 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TadCordle TadCordle

Labels
None yet
Projects
None yet
Milestone
v0.2.0-core
Development

No branches or pull requests
3 participants
@TadCordle @coollog @chanseokoh