Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing ProjectProperties.isWarProject() #1088

Closed
chanseokoh opened this issue Oct 2, 2018 · 1 comment
Closed

Consider removing ProjectProperties.isWarProject() #1088

chanseokoh opened this issue Oct 2, 2018 · 1 comment

Comments

@chanseokoh
Copy link
Member

chanseokoh commented Oct 2, 2018 •
edited
Loading

Conceptually it made sense that isWarProject() fits into ProjectProperties. At first, this method could be used in various places, but it turns out at the current state, it's used very rarely or not at all. Maybe we can just remove it.

(From #1068 (comment) and #1068 (comment).)
This was referenced Oct 2, 2018
Merged
Closed
@chanseokoh chanseokoh mentioned this issue Oct 23, 2018
Merged
@chanseokoh
Copy link
Member Author

chanseokoh commented Oct 23, 2018 •
edited
Loading

With the refactoring going on with #1163, conceptually it fits well that ProjectProperties determine sisWarProject. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chanseokoh