Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Java images container-friendly by default #289

Closed
saturnism opened this issue Feb 4, 2019 · 2 comments
Closed

Make Java images container-friendly by default #289

saturnism opened this issue Feb 4, 2019 · 2 comments

Comments

@saturnism
Copy link

set default container env var JAVA_TOOL_OPTIONS="-XX:+UseContainerSupport" similar to https://hub.docker.com/r/adoptopenjdk/openjdk11/
@briandealwis
Copy link
Member

According to JDK-8196595, UseContainerSupport was introduced in Java 10 (so not applicable to :8), and is enabled by default on Linux.

But we should enable necessary settings to make the :8 image more container-friendly.

@briandealwis briandealwis changed the title For Java images, set enable UserContainerSupport by default Make Java images container-friendly by default Feb 11, 2019
@briandealwis briandealwis mentioned this issue Feb 11, 2019
Merged
@chanseokoh
Copy link
Member

Multiple sources say UseContainerSupport is true by default, and -XX:-UseContainerSupport is there to disable it for those who want. So I also think it's unnecessary to set the option.

@briandealwis briandealwis mentioned this issue Feb 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@briandealwis @saturnism @chanseokoh