Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom upstream docker registries in google_artifact_registry_repository #2110

Open
rail opened this issue Mar 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@rail
Copy link

rail commented Mar 28, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave +1 or me too comments; they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If the issue is assigned to a user, that user is claiming responsibility for the issue.

Description

The docker_repository.public_repository section of google_artifact_registry_repository supports DOCKER_HUB only, see https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/artifact_registry_repository#nested_docker_repository and https://github.com/hashicorp/terraform-provider-google/blob/1ba50ab27d4185c49a77ede83e665d1152fa6860/google/services/artifactregistry/resource_artifact_registry_repository.go#L361

Google supports custom registries. For example, you can specify "https://quay.io" and get it worked.

It would be great to allow arbitrary upstream registries.

@rail rail added the enhancement New feature or request label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant