From f5c07374df49e29fa0dc66c61df354ec845456fe Mon Sep 17 00:00:00 2001 From: The Magician Date: Tue, 13 Oct 2020 15:31:09 -0700 Subject: [PATCH] Compute - Add update support for Network IP when changing network/subnetwork (#4030) (#549) * Compute - Add update support for Network IP when changing network/subnetwork * add field required by beta provider * error check for d.ForceNew * refactor functions into own file. introduce network-interface-helper * refresh instance after deleting alias config * correct bad merge * spelling fix * check error * Add forcenew unit test * resolve build issue * Update third_party/terraform/tests/resource_compute_instance_test.go.erb Co-authored-by: Cameron Thornton * Update third_party/terraform/tests/resource_compute_instance_test.go.erb Co-authored-by: Cameron Thornton * error couldn't convert to string * to type string * Refactored some test code for cleaner style and condensed some if statements * resolve merge issue with megan's change * update network interface helper to promote better go readability * fixed instances where incorrect name was referenced * removed extraneous dependencies and extrapolated self mutating operations * scrap refactor. only extrapolate functions when needed. * error check * resolved some fomatting and comment concerns. * find a comment a nice cozy new home on the hill side amongst all its comment friends. Truly truly a beautiful site to behold. Please be well and safe comment because the world needs you. YOU TOO are important * a comma boi * another commma for the party Co-authored-by: Cameron Thornton Signed-off-by: Modular Magician Co-authored-by: Cameron Thornton --- google/utils.go | 1 + 1 file changed, 1 insertion(+) diff --git a/google/utils.go b/google/utils.go index bf0e9886f..62c95cf75 100644 --- a/google/utils.go +++ b/google/utils.go @@ -24,6 +24,7 @@ type TerraformResourceData interface { } type TerraformResourceDiff interface { + HasChange(string) bool GetChange(string) (interface{}, interface{}) Get(string) interface{} Clear(string) error