-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: virtual repository multiple upstream_policies #13
Merged
prabhu34
merged 2 commits into
GoogleCloudPlatform:main
from
seedtag:fix-virtual-repo-upstreams
Feb 26, 2024
Merged
fix: virtual repository multiple upstream_policies #13
prabhu34
merged 2 commits into
GoogleCloudPlatform:main
from
seedtag:fix-virtual-repo-upstreams
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romancin
changed the title
Fix virtual repo upstreams
fix: virtual repository multiple upstream_policies
Feb 15, 2024
/gcbrun |
@romancin - thanks for the PR. Can you please rebase this with master? |
g-awmalik
approved these changes
Feb 26, 2024
romancin
force-pushed
the
fix-virtual-repo-upstreams
branch
from
February 26, 2024 13:37
c590129
to
ed767a8
Compare
Of course! Done! |
/gcbrun |
romancin
force-pushed
the
fix-virtual-repo-upstreams
branch
from
February 26, 2024 14:39
6985718
to
ed767a8
Compare
romancin
force-pushed
the
fix-virtual-repo-upstreams
branch
from
February 26, 2024 14:39
ed767a8
to
a616ded
Compare
/gcbrun |
prabhu34
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current module, defining multiple
upstream_policies
in thevirtual_repository_config
variable doesn't work, only the last one is applied.This PR changes this variable type so
upstream_configs
is a list. As an example of a working calling to this module using the changes included in this PR:This PR fixes #11